author | Alberto Bertogli
<albertito@blitiri.com.ar> 2017-03-01 00:18:25 UTC |
committer | Alberto Bertogli
<albertito@blitiri.com.ar> 2017-03-01 00:22:49 UTC |
parent | 0eeb964534f435413062ff676c72b7ad4894acc2 |
internal/courier/smtp.go | +1 | -1 |
internal/courier/smtp_test.go | +15 | -0 |
diff --git a/internal/courier/smtp.go b/internal/courier/smtp.go index 3fa98ad..d633649 100644 --- a/internal/courier/smtp.go +++ b/internal/courier/smtp.go @@ -72,7 +72,7 @@ func (s *SMTP) Deliver(from string, to string, data []byte) (error, bool) { a.stsPolicy = s.fetchSTSPolicy(a.tr, a.toDomain) mxs, err := lookupMXs(a.tr, a.toDomain, a.stsPolicy) - if err != nil { + if err != nil || len(mxs) == 0 { // Note this is considered a permanent error. // This is in line with what other servers (Exim) do. However, the // downside is that temporary DNS issues can affect delivery, so we diff --git a/internal/courier/smtp_test.go b/internal/courier/smtp_test.go index e1e624c..8b16b60 100644 --- a/internal/courier/smtp_test.go +++ b/internal/courier/smtp_test.go @@ -163,4 +163,19 @@ func TestSMTPErrors(t *testing.T) { } } +func TestNoMXServer(t *testing.T) { + fakeMX["to"] = []string{} + + s, tmpDir := newSMTP(t) + defer os.Remove(tmpDir) + err, permanent := s.Deliver("me@me", "to@to", []byte("data")) + if err == nil { + t.Errorf("delivery worked, expected failure") + } + if !permanent { + t.Errorf("expected permanent failure, got transient (%v)", err) + } + t.Logf("got permanent failure, as expected: %v", err) +} + // TODO: Test STARTTLS negotiation.