git » chasquid » commit e03594a

test: Make mail_diff more strict

author Alberto Bertogli
2023-12-23 14:08:36 UTC
committer Alberto Bertogli
2023-12-23 14:10:16 UTC
parent c4c330d7a437070467cbe0b0e4f9a6dcd5675df6
test: Make mail_diff more strict

This patch makes mail_diff more strict in its parsing, to ensure we
catch any encoding issues that may otherwise be masked by the default
compatibility policy.
test/util/mail_diff +11 -3 
diff --git a/test/util/mail_diff b/test/util/mail_diff
index 2523023..8659f4b 100755
--- a/test/util/mail_diff
+++ b/test/util/mail_diff
@@ -2,6 +2,7 @@
 
 import difflib
 import email.parser
+import email.policy
 import itertools
 import mailbox
 import sys
@@ -27,7 +28,7 @@ def flexible_eq(expected, got):
             posG += 1
             continue
         if c == '*':
-            while posG < len(got) and got[posG] != '\n':
+            while posG < len(got) and got[posG] != '\t':
                 posG += 1
                 continue
             continue
@@ -89,7 +90,14 @@ def msg_equals(expected, msg):
 if __name__ == "__main__":
 	f1, f2 = sys.argv[1:3]
 
-	expected = email.parser.Parser().parse(open(f1))
-	msg = email.parser.Parser().parse(open(f2))
+	# We use a custom strict policy to do more strict content validation.
+	policy = email.policy.EmailPolicy(
+			utf8=True,
+			linesep="\r\n",
+			refold_source='none',
+			raise_on_defect=True)
+
+	expected = email.parser.Parser(policy=policy).parse(open(f1))
+	msg = email.parser.Parser(policy=policy).parse(open(f2))
 
 	sys.exit(0 if msg_equals(expected, msg) else 1)