git » dnss » commit 0d6b056

DoH: Update references to point to draft #12

author Alberto Bertogli
2018-07-26 09:47:45 UTC
committer Alberto Bertogli
2018-07-26 09:47:45 UTC
parent ad1e9fd4418d8b0f81b7964f99f613972323f946
DoH: Update references to point to draft #12

The DoH code was written based on the draft 7, and current is 12. No
code changes are needed to adjust to the latter, this patch updates the
comments to make that explicit.

The diff between the two can be found at:
https://www.ietf.org/rfcdiff?url1=draft-ietf-doh-dns-over-https-07&url2=draft-ietf-doh-dns-over-https-12
internal/httpresolver/resolver.go +1 -1
internal/httpserver/server.go +2 -2 
diff --git a/internal/httpresolver/resolver.go b/internal/httpresolver/resolver.go
index 8bc2090..ac94878 100644
--- a/internal/httpresolver/resolver.go
+++ b/internal/httpresolver/resolver.go
@@ -25,7 +25,7 @@ import (
 // server via DNS over HTTPS.
 //
 // It supports two modes: JSON (like https://dns.google.com) and DoH
-// (https://tools.ietf.org/html/draft-ietf-doh-dns-over-https-07).
+// (https://tools.ietf.org/html/draft-ietf-doh-dns-over-https-12).
 type httpsResolver struct {
 	Upstream *url.URL
 	CAFile   string
diff --git a/internal/httpserver/server.go b/internal/httpserver/server.go
index 78c121c..bbb1462 100644
--- a/internal/httpserver/server.go
+++ b/internal/httpserver/server.go
@@ -7,7 +7,7 @@
 //    This is also implemented by Cloudflare's 1.1.1.1, as documented in:
 //    https://developers.cloudflare.com/1.1.1.1/dns-over-https/json-format/.
 //  - DNS Queries over HTTPS (DoH), as specified in:
-//    https://tools.ietf.org/html/draft-ietf-doh-dns-over-https-07.
+//    https://tools.ietf.org/html/draft-ietf-doh-dns-over-https-12.
 package httpserver
 
 import (
@@ -326,7 +326,7 @@ func stringToBool(s string) (bool, error) {
 }
 
 // Resolve DNS over HTTPS requests, as specified in
-// https://tools.ietf.org/html/draft-ietf-doh-dns-over-https-07.
+// https://tools.ietf.org/html/draft-ietf-doh-dns-over-https-12.
 func (s *Server) resolveDoH(tr trace.Trace, w http.ResponseWriter, dnsQuery []byte) {
 	r := &dns.Msg{}
 	err := r.Unpack(dnsQuery)