author | Alberto Bertogli
<albertito@blitiri.com.ar> 2020-09-28 18:57:34 UTC |
committer | Alberto Bertogli
<albertito@blitiri.com.ar> 2020-09-28 18:57:34 UTC |
parent | 330371ae5e59ef0fcf0c0f188df655db5ac46b10 |
debian/patches/0001-tests-Add-missing-conn.getresponse-which-was-causing.patch | +0 | -30 |
debian/patches/series | +0 | -1 |
diff --git a/debian/patches/0001-tests-Add-missing-conn.getresponse-which-was-causing.patch b/debian/patches/0001-tests-Add-missing-conn.getresponse-which-was-causing.patch deleted file mode 100644 index 61d840b..0000000 --- a/debian/patches/0001-tests-Add-missing-conn.getresponse-which-was-causing.patch +++ /dev/null @@ -1,30 +0,0 @@ -From: Alberto Bertogli <albertito@blitiri.com.ar> -Date: Sun, 29 Mar 2020 11:40:46 +0100 -Subject: tests: Add missing conn.getresponse() which was causing false - negatives - -Somewhere around Python 3.8, http.client.HTTPConnection objects changed -how result handling was done, and ignored SSL errors until -.getresponse() was called. - -This causes the test_no_local_cert to fail, even though the server is -responding correctly. - -This patch fixes this by adding a .getresponse() call, which forces -validation of the result and makes the test pass again. ---- - tests/run_tests | 1 + - 1 file changed, 1 insertion(+) - -diff --git a/tests/run_tests b/tests/run_tests -index d6d4ba2..9499bfe 100755 ---- a/tests/run_tests -+++ b/tests/run_tests -@@ -407,6 +407,7 @@ class TrickyRequests(TestCase): - conn = self.https_connection("localhost", 19840) - try: - conn.request("GET", "/v1/") -+ conn.getresponse() - conn.close() - except ssl.SSLError as err: - self.assertEqual(err.reason, "SSLV3_ALERT_BAD_CERTIFICATE") diff --git a/debian/patches/series b/debian/patches/series deleted file mode 100644 index 3196939..0000000 --- a/debian/patches/series +++ /dev/null @@ -1 +0,0 @@ -0001-tests-Add-missing-conn.getresponse-which-was-causing.patch