git » spf » commit d2b814b

test: Remove unnecessary "skip" from passing tests

author Alberto Bertogli
2026-08-23 11:46:31 UTC
committer Alberto Bertogli
2026-08-23 11:46:31 UTC
parent 856e3a769363512c3a917ebdf81b240327603d8c
test: Remove unnecessary "skip" from passing tests

Some of the tests were marked as "skip", but are currently passing after
recent changes.

This patch removes the now-unnecessary "skip" lines.
testdata/rfc4408-tests.yml +0 -5
testdata/rfc7208-tests.yml +0 -5 
diff --git a/testdata/rfc4408-tests.yml b/testdata/rfc4408-tests.yml
index f16cc83..2a66ffb 100644
--- a/testdata/rfc4408-tests.yml
+++ b/testdata/rfc4408-tests.yml
@@ -107,7 +107,6 @@ tests:
     host: 1.2.3.4
     mailfrom: "foobar@hosed2.example.com"
     result: permerror
-    skip: We don't enforce 7-bit ascii.
   non-ascii-result:
     description: >-
       SPF policies are restricted to 7-bit ascii.
@@ -414,7 +413,6 @@ tests:
     host: 1.2.3.5
     mailfrom: foo@t6.example.com
     result: fail
-    skip: Not worth the complexity of erroring on this.
   default-result:
     description: Default result is neutral.
     spec: 4.7/1
@@ -1880,7 +1878,6 @@ tests:
     host: 1.2.3.4
     mailfrom: foo@e19.example.com
     result: neutral
-    skip: Not worth the complexity of erroring on this.
   default-modifier-obsolete2:
     description: |
       Unknown modifiers do not modify the RFC SPF result.
@@ -1892,7 +1889,6 @@ tests:
     host: 1.2.3.4
     mailfrom: foo@e20.example.com
     result: neutral
-    skip: Not worth the complexity of erroring on this.
   non-ascii-exp:
     description: >-
       SPF explanation text is restricted to 7-bit ascii.
@@ -2174,7 +2170,6 @@ tests:
     host: 192.168.218.40
     mailfrom: test@e9.example.com
     result: pass
-    skip: We don't have a HELO-explicit mode.
   invalid-hello-macro:
     spec: 8.1/2
     description: |-
diff --git a/testdata/rfc7208-tests.yml b/testdata/rfc7208-tests.yml
index 3dbd041..9063dea 100644
--- a/testdata/rfc7208-tests.yml
+++ b/testdata/rfc7208-tests.yml
@@ -100,7 +100,6 @@ tests:
     host: 1.2.3.4
     mailfrom: "foobar@hosed2.example.com"
     result: permerror
-    skip: We don't enforce 7-bit ascii.
   non-ascii-result:
     description: >-
       SPF policies are restricted to 7-bit ascii.
@@ -454,7 +453,6 @@ tests:
     host: 1.2.3.5
     mailfrom: foo@t6.example.com
     result: fail
-    skip: Not worth the complexity of erroring on this.
   default-result:
     description: Default result is neutral.
     spec: 4.7/1
@@ -1969,7 +1967,6 @@ tests:
     host: 1.2.3.4
     mailfrom: foo@e19.example.com
     result: neutral
-    skip: Not worth the complexity of erroring on this.
   default-modifier-obsolete2:
     description: |
       Unknown modifiers do not modify the RFC SPF result.
@@ -1981,7 +1978,6 @@ tests:
     host: 1.2.3.4
     mailfrom: foo@e20.example.com
     result: neutral
-    skip: Not worth the complexity of erroring on this.
   non-ascii-exp:
     description: >-
       SPF explanation text is restricted to 7-bit ascii.
@@ -2294,7 +2290,6 @@ tests:
     host: 192.168.218.40
     mailfrom: test@e9.example.com
     result: pass
-    skip: We don't have a HELO-explicit mode.
   invalid-hello-macro:
     spec: 7.1/2
     description: |-